Prevent DoS by large str-int conversions¶
A Denial Of Service (DoS) issue was identified in CPython because we use binary bignum’s for our int implementation. A huge integer will always consume a near-quadratic amount of CPU time in conversion to or from a base 10 (decimal) string with a large number of digits. No efficient algorithm exists to do otherwise.
It is quite common for Python code implementing network protocols and data
serialization to do int(untrusted_string_or_bytes_value) on input to get a
numeric value, without having limited the input length or to do
log("processing thing id %s", unknowingly_huge_integer) or any similar
concept to convert an int to a string without first checking its magnitude.
(http, json, xmlrpc, logging, loading large values into integer via
linear-time conversions such as hexadecimal stored in yaml, or anything
computing larger values based on user controlled inputs… which then wind up
attempting to output as decimal later on). All of these can suffer a CPU
consuming DoS in the face of untrusted data.
Everyone auditing all existing code for this, adding length guards, and maintaining that practice everywhere is not feasible nor is it what we deem the vast majority of our users want to do.
This issue has been reported to the Python Security Response Team multiple times by a few different people since early 2020, most recently a few weeks ago while I was in the middle of polishing up the PR so it’d be ready before 3.11.0rc2.
After discussion on the Python Security Response Team mailing list the conclusion was that we needed to limit the size of integer to string conversions for non-linear time conversions (anything not a power-of-2 base) by default. And offer the ability to configure or disable this limit.
The fix adds
PYTHONINTMAXSTRDIGITS=digits environment variable,
int_max_str_digits=digits command line option and
sys.set_int_max_str_digits(digits) function to configure the new limit.
Use a limit of
0 digits to disable the limit. The fix also adds
sys.get_int_max_str_digits() function and
sys.int_info.default_max_str_digits (compiled-in default limit) and
sys.int_info.str_digits_check_threshold (lowest accepted value for the
json.load() denial of service was first reported as a public
pydantic issue in May
2020. Then it was reported to the Python Security Response Team by multiple
- Larry Yuan (May 5, 2020)
- Tom Christie (May 6, 2020) via Sebastián Ramírez
- Mike Gagnon (August 3, 2022)
- Disclosure date: 2022-08-08 (Python issue gh-95778 reported)
- Reported at: 2020-05-05 (PSRT email)
- Reported by: Larry Yuan
- Python 3.7.14 (2022-09-06) fixed by commit 15ec1af (branch 3.7) (2022-09-06)
- Python 3.8.14 (2022-09-06) fixed by commit b5e331f (branch 3.8) (2022-09-05)
- Python 3.9.14 (2022-09-06) fixed by commit cec1e9d (branch 3.9) (2022-09-05)
- Python 3.10.7 (2022-09-05) fixed by commit 8f0fa4b (branch 3.10) (2022-09-02)
- Python 3.11.0 (2022-10-24) fixed by commit f8b71da (branch 3.11) (2022-09-02)
CVE-2020-10735: Prevent DoS by large int<->str conversions.
- Python issue: gh-95778
- Creation date: 2022-08-08
- Reporter: gpshead
A flaw was found in python. In algorithms with quadratic time complexity using non-binary bases, when using int(“text”), a system could take 50ms to parse an int string with 100,000 digits and 5s for 1,000,000 digits (float, decimal, int.from_bytes(), and int() for binary bases 2, 4, 8, 16, and 32 are not affected). The highest threat from this vulnerability is to system availability.
- CVE ID: CVE-2020-10735
- Published: 2022-09-09
Timeline using the disclosure date 2022-08-08 as reference:
- 2020-05-05 (-825 days): Reported (PSRT email)
- 2022-08-08: Python issue gh-95778 reported by gpshead
- 2022-09-02 (+25 days): commit 511ca94 (branch 3.12)
- 2022-09-02 (+25 days): commit 8f0fa4b (branch 3.10)
- 2022-09-02 (+25 days): commit f8b71da (branch 3.11)
- 2022-09-05 (+28 days): commit b5e331f (branch 3.8)
- 2022-09-05 (+28 days): commit cec1e9d (branch 3.9)
- 2022-09-05 (+28 days): Python 3.10.7 released
- 2022-09-06 (+29 days): commit 15ec1af (branch 3.7)
- 2022-09-06 (+29 days): Python 3.7.14 released
- 2022-09-06 (+29 days): Python 3.8.14 released
- 2022-09-06 (+29 days): Python 3.9.14 released
- 2022-09-09 (+32 days): CVE-2020-10735 published
- 2022-10-24: Python 3.11.0 released
- pydantic potential DOS when loading malicious JSON by Samuel Colvin (May 5, 2020)
- Red Hat: CVE-2020-10735
- LWN: A Python security fix breaks (some) bignums (September 14, 2022)
- Python releases 3.10.7, 3.9.14, 3.8.14, and 3.7.14 are now available (September 7, 2022)